fix: avoid false delete events during atomic saves#5
Merged
ptheofan merged 1 commit intoptheofan:mainfrom Mar 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Open Markdown can mis-handle editor save workflows that temporarily unlink a file (for example Vim-style atomic/truncate+rewrite saves). The app currently treats
unlinkas an immediate delete, clears the open document, and shows a deleted-file error even when the file is recreated moments later.Solution
Treat delete events as pending and confirm them after a short grace period. If an
addorchangefor the same path arrives before confirmation, cancel the pending delete and process the update normally.What Changed
FILE_DELETE_CONFIRM_MS(750ms) in shared constants.FileWatcherServiceto:unlinkinstead of immediate delete,addandchange,addhandler registration,unlink -> addandunlink -> changepaths (no delete emitted),AI Disclosure
I used AI assistance (OpenAI Codex) to help draft and implement the code changes and tests, and to prepare this PR description. I personally reviewed and validated the final patch and test results, and tested the app works as expected with
pnpm start, before opening this PR, though I am not a frontend expert by any means.