Conversation
…ethod to ActionVisitor class
…d added to Team.java
ptal
requested changes
May 20, 2021
Owner
ptal
left a comment
ptal
left a comment
There was a problem hiding this comment.
Nice contribution. I have two concerns however:
- Can all champions use all spells? I think both archer and warrior can use the double damage spell.
- There is no cooldown on the spell, so instead of attacking "normally", we can always use the spell instead, is that right?
| } | ||
|
|
||
| //for damage spells | ||
| public boolean attackEnhanced(Destructible d, int factor) { |
Owner
There was a problem hiding this comment.
You can create a private attack(Destructible d, int damage) method that is used by both attackEnhanced and attack (to avoid code duplication).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A structure for adding spells has been created and a spell that deals double damage has been added.