Round Robin tournament mode added to the game. by pitbaum · Pull Request #46 · ptal/lol2D

pitbaum · 2021-05-18T09:07:18Z

Here my commit for the tournament mode. To execute the program, enter after having started the server the amount of clients you want to connect. If there are more then 2 clients connected, the tournament mode will be opened.

Known Bugs:
Currently the program will quit the execution of the program for the clients that have played a round in the tourney against each other.
Also sometimes the spawn of the red team doesnt work, i am not sure why it just sometimes happens.

…ased tourney seed

… of players in the end of the tourney. New UID handeling.

ptal · 2021-05-18T10:00:04Z

For the spawn of the red team, see #38, it is not because of your code.

ptal

That's a great start, but I understand why you have bugs.

Please try to refactor your code as follows:

Create a Game.java class which takes two players and make them fight against each other.
Create a RoundRobinTourney.java class which is only busy with the tourney, and rely on Game to run the matches.
Since a new Game instance is created for each matchup, you don't need to reset the Battlefield and view, etc.
The Server class should be used to wait the players (in the beginning), and launch either a single Game, or the RoundRobinTourney.

Also, because a client can play several games, you will need to modify Client.java as well. Because for now, it only plays a single game and then exits.

src/main/java/lol/game/Nexus.java

src/main/java/lol/game/Destructible.java

src/main/java/lol/server/Player.java

…ishing the tourney, when all the matches were done.

pitbaum

The game.java file was added and i made some changes such that the client will be waiting until the server sends over the final scores of the tourney.
To implement the game.java and update and renew the battlefield/arena, i needed to make some small adjusments to the ui and the battlefieldViewer. In which i suppose i have not understood how the tiles are specifically updated, thus the server will throw an Error between the first and second round, about some old tiles not being updated. This error does not cuase any noticable problem, the program will still run as expected.
A bigger issue is that the server now throws a null pointer exception when the tourney is over and doesnt get to the sending of the scores to the users.
In the end, the current version runs all the matches necessary and then the server throws an exception, keeping the clients wait forever for some feedback of the final results.

ptal

Overall, that's an awesome contribution, congratz!

There are some comments because there are a lot of code.

I'm not sure we need to send the results to the clients, just send them an UID > 2 to force them terminating (since it is your condition). The null pointer exception might be because of the dummy player (as explained below).

I'd expect the server to display the result table of the players.

ptal · 2021-05-20T09:30:11Z

src/main/java/lol/ui/BattlefieldView.java

    sprites = new Sprites();
  }

+  public void generateNewBattlefieldView(Battlefield battlefield) {


Instead of having this method, wouldn't it be more convenient to just recreate the object BattlefieldView each time we start a new game? That might solve your first issue as well.

ptal · 2021-05-20T09:30:44Z

src/main/java/lol/server/Server.java

+  private void roundOrganizer(Player playerGroup1, Player playerGroup2) throws IOException {
+    Player bluePlayer = playerGroup1;
+    Player redPlayer = playerGroup2;
+    bluePlayer.setRoundUID(0);


Use Nexus.BLUE/RED instead of 0/1 constant please (occur in several places in the code).
You can also use an array of players (of only two elements), to avoid repeating the code. For instance it would allow you to write updateScores(players[winner]) instead of having a conditional.

ptal · 2021-05-20T09:33:39Z

src/main/java/lol/server/Server.java

+  public void registrationPhase() throws IOException {
+    Scanner scanner = new Scanner(System.in);
+    System.out.println("Enter the number of participants for the tourney/match: ");
+    int expectedParticipants = scanner.nextInt();


Optional modification: It would be better if the number of players were passed an argument to the program, e.g., retrieved in args of the main function. This will simplify the automation of the tournament.

ptal · 2021-05-20T09:36:28Z

src/main/java/lol/client/Client.java

-      // Now the turn-based game starts until the game is over.
-      arena.startGamePhase();
-      gameLoop();
+      while(1 == 1) {


Write while(true) instead.
It would be better to have a "real" condition, such as while(teamID < 2)
Alternatively, you can write while(receiveUIDOrStop()) where this method is just receiveUID which returns teamID < 2.

ptal · 2021-05-20T09:39:38Z

src/main/java/lol/client/Client.java

+        turn.send(socket);
+        System.out.println("sent");
+        allChampionSelection();
+        System.out.println("allCham");


Please, remove the debugging messages (sent, allCham) for me :-) (I forgot to do that).

ptal · 2021-05-20T09:41:40Z

src/main/java/lol/client/Client.java

    }
  }

+  private void updateEnvironment() {


Rename prepareEnvironment. Also since you have this method here, you can remove the code in the main which does the same.

ptal · 2021-05-20T09:43:18Z

src/main/java/lol/server/Game.java

+        arena.applyTurn(turn);
+        ui.update();
+        broadcast(turn);
+        wait(2000);


I'm not sure we want to wait that long if it's a tourney, depending on the numbers of AI how much time a single tourney can take?

ptal · 2021-05-20T09:45:08Z

src/main/java/lol/server/Server.java

-        System.out.println("LOSER: " + nexus);
-      }
+    if(group2.size() < group1.size()) {
+      group2.add(null); //add dummy player.


That's risky to add null, it could lead to NullPointerException of not dealt with care. Couldn't we just check the group size instead of checking the null in the remaining of the code?

ptal · 2021-05-20T09:46:03Z

src/main/java/lol/server/Server.java

+    //Dummy player round is skipped.
+    int set = 0;
+    int round = 0;
+    while(set < (int)((double)((group1.size()+group2.size())/2)*((group1.size()+group2.size())-1))) {


Add some messages on the terminal to write who is fighting against who, and the result.

pitbaum added 2 commits May 13, 2021 19:23

implementation of tourney organization, round organization of color b…

0fbd096

…ased tourney seed

update on round robin rules and new functionality to print out scores…

63eafef

… of players in the end of the tourney. New UID handeling.

ptal requested changes May 18, 2021

View reviewed changes

src/main/java/lol/game/Nexus.java Outdated Show resolved Hide resolved

src/main/java/lol/game/Destructible.java Outdated Show resolved Hide resolved

src/main/java/lol/server/Player.java Outdated Show resolved Hide resolved

pitbaum and others added 3 commits May 19, 2021 16:32

Works for the rounds but throws a null pointer instead of closing/fin…

81e8400

…ishing the tourney, when all the matches were done.

Update Client.java

645e878

Update Destructible.java

308c02a

pitbaum commented May 19, 2021

View reviewed changes

pitbaum requested a review from ptal May 19, 2021 14:49

ptal requested changes May 20, 2021

View reviewed changes

Conversation

pitbaum commented May 18, 2021

Uh oh!

ptal commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ptal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pitbaum left a comment

Choose a reason for hiding this comment

Uh oh!

ptal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptal commented May 18, 2021 •

edited

Loading

ptal left a comment •

edited

Loading