Open
Conversation
Author
|
@psxpaul Did you have a chance to review this PR? I would love to have this bug fixed in my Gradle build. |
Owner
|
Hi @hesch sorry for the long delay. I don't have a windows machine, so I can't duplicate the bug you're seeing in IntelliJ. I did have some concerns around this approach. The unit test implies that any ending \r character would get swallowed. And on Unix machines I wonder if this would replace all \r\n with just \n. That might be desirable for some people, but not others. |
psxpaul
reviewed
Apr 13, 2021
| val character = b.toChar() | ||
| if (character == '\n') { | ||
| if (wasCR || character == '\n') { | ||
| logger.lifecycle(sb.toString()) |
Owner
There was a problem hiding this comment.
Would it make sense to instead remove any ending \r character here? And maybe only do that if the System.lineSeparator() is \r\n.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a bug where the output of the process was not shown on Windows in IntelliJ. The reason for this bug was, that the process is logging lines CRLF line endings. I changed the behaviour of the OutputStreamLogger-Class to handle CRLF, LF and CR line endings.