Add ltd. with a full-stop to the Limited list
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where `ltd.` was not being picked up when matching by type. A better solution would be making the search agnostic on ending full stops, potentially.
gertct
approved these changes
Dec 12, 2024
Author
|
@psolin Any chance we could get a review on this? |
Contributor
|
@lewis-wf so sorry for the long review time but I added a TON of endings and this now has conflcits. Can you please resolve them? |
Contributor
|
@psolin can you clean this up in two seconds and merge it? We need to promptly review contributions to encourage them. I can be maintainer if you're busy - I'm chewing this dirt daily :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
ltd.was not being picked up when matching by type. A better solution would be making the search agnostic on ending full stops, potentially.