Update !ping to react to msg as well as replying #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskillen
approved these changes
Mar 15, 2025
Owner
pskillen
left a comment
pskillen
left a comment
There was a problem hiding this comment.
Tested on the hardware, all looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved a large refactor, as all simple features must
Pulled a lot of the common functionality of 'commands' and 'responders' out into an abstract BaseFeature class. Did my best to unify the functionality, update tests, etc.
There's still a bit of work required around the abstract base classes for tests, since we should be testing the base feature class, and supporting testing all the bells and whistles each command/responder can now perform
Oh, I also implemented the improvement to
!ping