Added simple diagram and graphing infrastructure.#15
Draft
zoalasaurusrawr wants to merge 3 commits intomainfrom
Draft
Added simple diagram and graphing infrastructure.#15zoalasaurusrawr wants to merge 3 commits intomainfrom
zoalasaurusrawr wants to merge 3 commits intomainfrom
Conversation
- Creates a simple AST of the state machine which should be full serializable to anything - Added a mermaid state diagram writer with support for signal type info
aidapsibr
requested changes
Mar 15, 2022
Contributor
aidapsibr
left a comment
aidapsibr
left a comment
There was a problem hiding this comment.
Things I found:
Nested states/signals should be represented with DeclaringType.NestedType.FinalType name format
re-entrant states aren't displaying.
|
|
||
| namespace PSIBR.Liminality | ||
| { | ||
| public class VisualizationTests : IClassFixture<BasicStateMachineFixture> |
Contributor
There was a problem hiding this comment.
Things I found:
- Nested states/signals should be represented with DeclaringType.NestedType.FinalType name format
- re-entrant states arent displaying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still very ugly, so opening as draft at first. I'll open it as a full PR once I get the rendering endpoint in place that integrates the diagram with a visualization JS lib