-
Notifications
You must be signed in to change notification settings - Fork 3
Voting identities #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Voting identities #688
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # packages/indexer/src/processor/psql/dao/identities.rs
packages/api/test/utils/fixtures.js
Outdated
| } | ||
|
|
||
| if (!type) { | ||
| type = 'Regular' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use enum, and why is it CamelCase
| let identifier: String = row.get(2); | ||
| let revision: i32 = row.get(3); | ||
| let is_system: bool = row.get(4); | ||
| let sql_identity_type: String = row.get(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it sql_identity_type?
| pub revision: Revision, | ||
| pub balance: Option<u64>, | ||
| pub is_system: bool, | ||
| pub identity_type: IdentifierType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing masternode and voting address
This reverts commit 75df2ee.
Issue
At this moment indexer doesn't support identities, which used for voting
Things done
Regular,Masternode,Voting)