Skip to content

Conversation

@LexxXell
Copy link

@LexxXell LexxXell commented Jan 3, 2025

Migrate DIP3 Masternodes to New BLS Scheme

This pull request introduces support for payload version 2 in the ProUpServTx implementation, marking a significant migration of masternodes to the new BLS key scheme.

Key Changes:

  1. Support for ProTx Payload Version 2:

    • Implemented logic to handle serialization and signing for version 2 using the BasicSchemeMPL approach.
    • Maintained backward compatibility with version 1 to ensure a smooth transition for existing masternodes.
  2. Code Review and Updates:

    • The previous implementation was partially functional; some features worked as expected, while others did not.
    • Reviewed and updated the codebase to address inconsistencies and ensure robust support for the new key scheme.
    • Addressed issues related to legacy masternodes running on the older version.
  3. Breaking Changes:

    • Masternodes now operate using a new key format in compliance with the updated BLS scheme.
    • This migration renders the previous key format obsolete, requiring node operators to update accordingly.
  4. Validation Enhancements:

    • Added checks to gracefully handle unsupported payload versions, improving the reliability of the system.
  5. Thorough Testing:

    • Verified compatibility and consistency across both version 1 and version 2 payloads.
    • Comprehensive testing ensures the reliability of the migration process.

Notes:

@pshenmic pshenmic changed the title Add support for payload version 2 in ProUpServTx (Closes #27) Migrate DIP3 Masternodes to New BLS Scheme Jan 8, 2025
@pshenmic pshenmic merged commit 9b35f6c into pshenmic:develop Jan 8, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants