Skip to content

moving plugins and modifying gitpress_utils.sh#11

Open
forgondolin wants to merge 1 commit intopschoffer:masterfrom
forgondolin:feature/mu-plugins
Open

moving plugins and modifying gitpress_utils.sh#11
forgondolin wants to merge 1 commit intopschoffer:masterfrom
forgondolin:feature/mu-plugins

Conversation

@forgondolin
Copy link
Contributor

No description provided.

@pschoffer
Copy link
Owner

Sorry @forgondolin , I finally got to test this.

I am trying in the seed mode and i get this error.

...
Step 11/14 : COPY bin/* /usr/local/bin/
 ---> ab8d0db0fa9d
Step 12/14 : COPY plugins/* /usr/src/versionpress/
ERROR: Service 'gitpress' failed to build: COPY failed: no source files were specified

The new way of doing it needs to copy the mu-plugins somewhere, and then both seed and restore needs to either copy but probably better symlink that there.

So something like for the dockerfile:
COPY mu-plugins /usr/src/mu-plugins

And then something like ln -s /usr/src/mu-plugins <wp-location>/wp-content/mu-plugins in the entrypoint scripts

WE might also need some .gitignore so that the mu-plugins won't be commited with the content code.

^^^ those are just for illustration I haven't tested those:)

@pschoffer pschoffer mentioned this pull request Oct 5, 2020
@pschoffer
Copy link
Owner

Solving - #5

@forgondolin
Copy link
Contributor Author

COPY plugins/* /usr/src/versionpress/ ... wow thats weird, well I think I've let that pass. but I'll fix it

@pschoffer
Copy link
Owner

BTW the symlink needs to be created after we got the content, so that would be in the entry script not in Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants