Skip to content

Partially cleanup inc_curr_1vb_split#375

Merged
JamesMcClung merged 16 commits intopsc-code:mainfrom
JamesMcClung:pr/some-curr-cleanup
Jan 21, 2026
Merged

Partially cleanup inc_curr_1vb_split#375
JamesMcClung merged 16 commits intopsc-code:mainfrom
JamesMcClung:pr/some-curr-cleanup

Conversation

@JamesMcClung
Copy link
Collaborator

Major/notable changes:

  1. Use new Vec methods in inc_curr_1vb_split
  2. Use Vec3 in many places where array pointers were previously used
  3. Cite the source of each current deposition technique in comments

Copy link
Contributor

@germasch germasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

As you were replacing gt::sarray with Vec3, this kinda reminded me that actually it'd be great to have Vec3 to just be an alias for the former. Eventually, as usual, with some specific exceptions (like cross really only makes sense for length-3 arrays).

I could have realized that earlier, when you added various capabilities to Vec3, though I'd admit that even me myself would be somewhat scared to touch gtensor right now, as it's been sitting pretty much unmaintained for quite a while...

@JamesMcClung
Copy link
Collaborator Author

The alias thing occurred to me too, but I certainly wasn't going to touch gtensor. And yeah, cross is a bit of a hack right now.

@JamesMcClung JamesMcClung merged commit eaf9319 into psc-code:main Jan 21, 2026
6 checks passed
@JamesMcClung JamesMcClung deleted the pr/some-curr-cleanup branch January 21, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants