Merged
Conversation
germasch
approved these changes
Jan 15, 2026
Contributor
germasch
left a comment
There was a problem hiding this comment.
👍 Thanks!
For the multi-d iteration, I guess I'll say that generally it'd be preferable to get rid of such loops altogether, and instead use gtensor expressions. But that's a bigger project, and may not work everywhere, anyway.
69c0f0d to
76d7f5f
Compare
Collaborator
Author
|
What gtensor expressions do you mean? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly adds lots of mathematical methods to Vec:
sum,prod,mag,mag2fintdotandcrossminandmaxinvVecRangeAlso adds an overload to
rng::Uniform::get.Most of these features aren't used in this PR. Future PRs will use them extensively, however.