Merged
Conversation
germasch
approved these changes
Jan 7, 2026
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
I guess I'll officially approve it, too, though I guess it's not required. Do you have permission to merge?
Collaborator
Author
|
I do have permission to merge, and I do so when only my cases are affected. This PR updates the docs with an arguably bad suggestion, though (undermining the idea of PSC cases being self-contained). I should have specifically pointed that out in the original post, but better late than never. |
JamesMcClung
force-pushed
the
pr/params-cleanup
branch
from
1f423c0 to
07dd4e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add doc comments, improve error messages, improve boolean parsing, and move/rename to InputParams.