Fix reflective BC moment calculations#354
Merged
germasch merged 56 commits intopsc-code:mainfrom May 5, 2025
Merged
Conversation
it has to run on debug mode, because otherwise the asserts aren't compiled
This way is clearer, more reliable, and yields a cleaner error message than the assert in checks_impl. The latter might be removed without realizing tests depend on it, and leads to the pitfall where tests erroneously pass when accidentally compiled in release mode.
revert this if it's horribly inefficient
Collaborator
Author
|
It runs on my machine 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_ghosts_reflecting_hiandadd_ghosts_reflecting_lofromfields_item.hxxtoadd_ghosts_reflecting.hxxdlibpsc/tests/test_reflective_bcs.cxx, including an "integration" test performs gauss and continuity checks for particles bouncing off an upper and lower wall