Draft: Test and fix reflective BCs#352
Closed
JamesMcClung wants to merge 24 commits intopsc-code:mainfrom
Closed
Conversation
it has to run on debug mode, because otherwise the asserts aren't compiled
This way is clearer, more reliable, and yields a cleaner error message than the assert in checks_impl. The latter might be removed without realizing tests depend on it, and leads to the pitfall where tests erroneously pass when accidentally compiled in release mode.
revert this if it's horribly inefficient
JamesMcClung
force-pushed
the
wip/test-reflective-bcs
branch
from
2ffb146 to
4131f1f
Compare
germasch
approved these changes
Apr 18, 2025
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
LGTM. I think the compiler should be able to optimize this to about the same, and it's not likely that this function is going to be a bottleneck in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.