Converting Code to New API #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleaned up code and converted to easier to use JSON format.
Updated metar.py to include new API
Updated configuration settings for wind and lightning animations, and adjusted daytime dimming options.
gth758y
reviewed
Oct 6, 2025
gth758y
left a comment
gth758y
left a comment
There was a problem hiding this comment.
Thanks for putting this together. It worked for me, but I'd suggest adding some error handling for incomplete METARs. For instance, VUO is currently not reporting a visibility, which caused this error: ValueError: invalid literal for int() with base 10: ''
… nearest airport flt cat if missing
Author
|
Thanks for the tip! I should have added a more robust section there, just kinda threw something together to get it working. I've added all that functionality and even added a new feature. If REPLACE_CAT_WITH_CLOSEST (a new config option) is set to True, then the code will find the nearest METAR (from your airports list) and show that category so that you don't just have a blank there. |
… it existed in the display airports file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Just noticed my METARMap failing - no idea why it took me so long to notice. Saw a few people offering fixes, but I went a bit more nuclear. The new metar.py should be good to go now and has been working for me, including lightning and wind gusts. I also moved to JSON instead of XML and cleaned up a bunch of the code. Ideally I would have done more but didn't really understand how the external display code worked and didn't want to cause that to break.
Things I was unable to test:
Let me know if anyone sees any issues with the updates! Should hopefully be plug and play, I tried to match both the inputs and outputs of the old code.