Attempt to make V2 meeting and webinar APIs consistent for start_time#373
Open
pjkundert wants to merge 1 commit intoprschmid:developfrom
Open
Attempt to make V2 meeting and webinar APIs consistent for start_time#373pjkundert wants to merge 1 commit intoprschmid:developfrom
pjkundert wants to merge 1 commit intoprschmid:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing a start_time for Webinar's and Meeting's create and update actions is inconsistent between V1 and V2, making it difficult to write code that handles both Meetings and Webinars.
I improved the consistency, and also detect that a datatime.datetime or .date was provided before attempting to convert it to a str using util.date_to_str.