Conversation
|
Released new canary packages: |
|
Released new canary packages: |
|
Released new canary packages: |
src/client/proximaStreamClient.ts
Outdated
| this.clients[endpoint] ?? | ||
| (this.clients[endpoint] = new StreamDBConsumerClient(endpoint)) | ||
| this.clients[endpoint.uri] ?? | ||
| (this.clients[endpoint.uri] = new StreamDBConsumerHttpClient(endpoint.httpUri ?? endpoint.uri)) // todo: throw? |
There was a problem hiding this comment.
@ivanbenko is it better to throw exception here or maybe try to generate that uri by adding '-rest' to the deepest subdomain (streams.buh.proxima.one -> streams-rest.buh.proxima.one)?
|
Released new canary packages: |
|
Released new canary packages: |
| offset: Offset, | ||
| controller?: StreamController | ||
| ): PausableStream<StreamEvent> { | ||
| return PausableStream.create<StreamEvent>((observer, _) => { |
There was a problem hiding this comment.
@ivanbenko is it necessary to use PauseState here? I haven't dove deeply into its internals
There was a problem hiding this comment.
yes, pauseState is important. Client should react to its state. It's being used by Buffered Reader to prevent overconsuming events
|
Released new canary packages: |
|
Released new canary packages: |
|
Released new canary packages: |
| export function getConsumerClientFactory() { | ||
| const factories = {}; | ||
|
|
||
| // todo: can we have both clients on node.js ? |
There was a problem hiding this comment.
If we will be implementing this in the future it's worth mentioning that websockets are not working properly inside Node.js out of the box for some reason. So websocket client for Node.js won't be only about client creation
kalabukdima
force-pushed
the
master
branch
2 times, most recently
from
546c24f to
3e92b0c
Compare
2 participants
No description provided.