fix(theme): remove dead code and improve coverage#64
Merged
Conversation
- Remove dead code in run.sh (--detect/--list handling, theme_detect failure) main.sh handles these flags before calling theme_run - Add tests for THEME=light env fallback and invalid --detect override - Add kcov-exclude for directory-not-exists check (defensive code)
📊 Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Dead Code Removed
--detecthandling in run.sh (main.sh handles this flag before calling theme_run)--listhandling in run.sh (main.sh handles this flag before calling theme_run)theme_detectfailure handling in run.sh (override is validated before theme_detect is called)Tests Added
THEME=lightenvironment variable fallback--detectflagkcov-exclude Markers
Coverage
Before: 90.98% → After: Should be ~100%