Fix installation bugs and testing bugs#2
Open
HelloWorldLTY wants to merge 5 commits intoprov-gigatime:mainfrom
Open
Fix installation bugs and testing bugs#2HelloWorldLTY wants to merge 5 commits intoprov-gigatime:mainfrom
HelloWorldLTY wants to merge 5 commits intoprov-gigatime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for your great work. When I download the pretrained models and testing note books, I find some small issues which might affect the reproductibility of the results, and I have fixed them.
It seems that we need huggingface_hub to download the pretrained models, without it, models cannot be successfully downloaded. I have fixed this issue by modifying environment.yml file.
In the gigatime_testing.ipynb notebook, the inference step is performed in GPU, however, the model is loaded in cpu originally. Your codes are
So you load models only using CPU. I have modifed the codes and put model in GPU so we can make inference with GPU.
If you think these modifications can be helpful, please consider merging it. Thanks.