feat(pubsub): implement PubSubQueue for horizontal scaling #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added detailed phase for PubSubQueue implementation: - Async bridge pattern (sync Pub/Sub callback → asyncio.Queue → async workers) - JSON serialization for simplicity and consistency - Dual DLQ (Pub/Sub DLQ + ErrorStore) - Resource management for dev/test environments - Complete code patterns and design decisions Estimated: 7-9 hours Dependencies: Phase 4 (Processor, EventQueue protocol)
- Add PubSubQueue implementing EventQueue protocol - Async bridge: Pub/Sub sync callbacks → asyncio processing pipeline - Configurable workers, topic/subscription management - DLQ support with max delivery attempts - Graceful shutdown with queue draining - 96% code coverage with comprehensive unit tests - Mocked PublisherClient/SubscriberClient for fast unit testing
- Update create_queue() to support PUBSUB mode - Export PubSubQueue from queues package - Update factory tests to verify PubSubQueue creation - All 25 queue tests passing
- Add pubsub-emulator service to docker-compose.yml - Create comprehensive integration tests for PubSubQueue: * End-to-end publish → subscribe → process * Multiple workers parallel processing * Graceful shutdown with queue draining * Message acknowledgment (no redelivery) * Resource creation (topics/subscriptions) - Update CI workflow to start Pub/Sub emulator - Add PUBSUB_EMULATOR_HOST to test environment - All 5 integration tests passing
- Update LOCAL_DEV.md: Add Pub/Sub emulator setup, queue mode options - Update CLAUDE.md: Add Pub/Sub async bridge pattern, command updates - Update tasks.md: Mark Task 16 (PubSubQueue) as complete - Document sync-to-async bridge using asyncio.run_coroutine_threadsafe - Add queue mode configuration examples for all three modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements to enable horizontal scaling of event processing using Google Cloud Pub/Sub.
Changes
Core Implementation (4 commits):
PubSubQueue Implementation: Full async queue with Pub/Sub integration
asyncio.run_coroutine_threadsafeFactory Integration: Updated
create_queue()to supportEVENTKIT_QUEUE_MODE=pubsubCI & Integration Tests:
Documentation:
LOCAL_DEV.mdwith Pub/Sub setup, queue modes, test isolationCLAUDE.mdwith async bridge patterntasks.mdTest Coverage
Configuration
New environment variables:
EVENTKIT_QUEUE_MODE=pubsub(enable Pub/Sub queue)EVENTKIT_PUBSUB_TOPIC(default: eventkit-events)EVENTKIT_PUBSUB_SUBSCRIPTION(default: eventkit-worker)EVENTKIT_PUBSUB_DLQ_TOPIC(default: eventkit-events-dlq)EVENTKIT_PUBSUB_WORKERS(default: 4)EVENTKIT_PUBSUB_MAX_DELIVERY_ATTEMPTS(default: 5)Closes #18