-
Notifications
You must be signed in to change notification settings - Fork 76
adds roave bc checker #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
weird. locally these are filtered out... https://github.com/prooph/event-store/actions/runs/14241242016/job/39911435244?pr=448#step:3:700 |
|
@unixslayer what do you think? |
|
It checks for BC breaks you are introducing in your library, exposed to others. Vendor libraries changing can lead to changes in your libraries, which in turn can lead to exposed BC breaks for others, but that's just one possible case |
.github/workflows/integration.yaml
Outdated
| fetch-depth: 0 | ||
| - name: "Check for BC breaks" | ||
| run: | | ||
| composer require --dev roave/backward-compatibility-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pinning to an exact version.
Ideally, you would lock with a dedicated composer.lock
|
Don't think it does that. I've tested locally. Added a method to an interface and committed. Then ran the check and it blocked. |
ok. I didn't commit when testing locally but when I did, it showed me I'm introducing a BC Break. Maybe only pin to an exact version like @Ocramius suggested and we're good to go. |
test this