Add external_id support for AWS role assumption#52
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Jan 6, 2026
Merged
Add external_id support for AWS role assumption#52roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie merged 1 commit intoprometheus:mainfrom
Conversation
AWS recommends using external IDs to prevent the confused deputy problem when granting cross-account access. This adds an optional external_id configuration field that is passed to STS AssumeRole when role_arn is specified. The implementation follows the same pattern as Prometheus core (prometheus/prometheus#17171) and uses the AWS SDK v2 functional options pattern to conditionally set the external ID only when provided. Fixes prometheus#46. Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
SuperQ
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS recommends using external IDs to prevent the confused deputy problem when granting cross-account access. This adds an optional external_id configuration field that is passed to STS AssumeRole when role_arn is specified.
The implementation follows the same pattern as Prometheus core (prometheus/prometheus#17171) and uses the AWS SDK v2 functional options pattern to conditionally set the external ID only when provided.
Fixes #46.