feat: Make handling of invalid devices configurable#266
Open
Hayajiro wants to merge 1 commit intoprometheus-community:masterfrom
Open
feat: Make handling of invalid devices configurable#266Hayajiro wants to merge 1 commit intoprometheus-community:masterfrom
Hayajiro wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Currently, whenever there are devices that are invalid, smartctl_exporter will log an error stating that the device can not be opened, refering to potential issues with missing IDENTIFY_DEVICE structures or low-power-mode-devices. There are, however, also situations where (virtual) devices disappear from the host and are not properly cleaned up. Here, `open()`ing the device in smartctl fails with ENXIO, resulting in the error message "No such device or address" being returned. In this case, the error just clutters the log output for no reason, as there is no reasonable action that can be taken. This MR makes the experienced behavior for such cases configurable. One can either specify the newly added flag `--smartctl.exclude-enxio` to ensure that devices with such problems are simply silently ignored, or decide to ignore the flag and continue experiencing the current behavior. Signed-off-by: Markus Kostrzewski <markus.kostrzewski@hetzner.com>
Hayajiro
force-pushed
the
make_enxio_device_handling_configurable
branch
from
35746fc to
c9b41df
Compare
Author
|
@SuperQ not wanting to sound impatient, but is there a timeframe for when this change could be looked at? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whenever there are devices that are invalid, smartctl_exporter will log an error stating that the device can not be opened, refering to potential issues with missing IDENTIFY_DEVICE structures or low-power-mode-devices.
There are, however, also situations where (virtual) devices disappear from the host and are not properly cleaned up. Here,
open()ing the device in smartctl fails with ENXIO, resulting in the error message "No such device or address" being returned. In this case, the error just clutters the log output for no reason, as there is no reasonable action that can be taken.This MR makes the experienced behavior for such cases configurable. One can either specify the newly added flag
--smartctl.exclude-enxioto ensure that devices with such problems are simply silently ignored, or decide to ignore the flag and continue experiencing the current behavior.