Add support for zone statistics#173
Open
smrekarm12 wants to merge 2 commits intoprometheus-community:masterfrom
Open
Add support for zone statistics#173smrekarm12 wants to merge 2 commits intoprometheus-community:masterfrom
smrekarm12 wants to merge 2 commits intoprometheus-community:masterfrom
Conversation
Signed-off-by: Mateja Smrekar <mateja.smrekar1@gmail.com>
Signed-off-by: Mateja Smrekar <mateja.smrekar1@gmail.com>
|
Would very much like to see this merged. :) |
heo4200000
reviewed
Apr 13, 2025
| for _, x := range zone.Counters { | ||
| switch x.Type { | ||
| case rcode: | ||
| z.ZoneRcode = x.Counters |
heo4200000
approved these changes
Apr 13, 2025
heo4200000
approved these changes
Apr 13, 2025
|
Can this get merged? Need any help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for per zone metrics. This partially implements #13.
This is my first experience with Go, so let me know if there is anything to fix.
I can add json support once this is marked ok.