Out-of-order Flag : Added option for sending out of order samples#68
Merged
bwplotka merged 3 commits intoprometheus-community:mainfrom Sep 16, 2024
Merged
Out-of-order Flag : Added option for sending out of order samples#68bwplotka merged 3 commits intoprometheus-community:mainfrom
bwplotka merged 3 commits intoprometheus-community:mainfrom
Conversation
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshika <102902652+Vanshikav123@users.noreply.github.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
bwplotka
approved these changes
Sep 16, 2024
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, just one suggestion, thanks!
| remoteTenant = kingpin.Flag("remote-tenant", "Tenant ID to include in remote_write send").Default("0").String() | ||
| tlsClientInsecure = kingpin.Flag("tls-client-insecure", "Skip certificate check on tls connection").Default("false").Bool() | ||
| remoteTenantHeader = kingpin.Flag("remote-tenant-header", "Tenant ID to include in remote_write send. The default, is the default tenant header expected by Cortex.").Default("X-Scope-OrgID").String() | ||
| outOfOrder = kingpin.Flag("out-of-order", "Enable out-of-order timestamps in remote write requests").Default("true").Bool() |
Member
There was a problem hiding this comment.
Nice!
One idea, instead of a bool should we have a flag like out-of-order.min-time which would control the minimum time this can go back in time?
Member
There was a problem hiding this comment.
It's fine to do it in another PR though, thanks!
Contributor
Author
There was a problem hiding this comment.
okkay! i will raise another PR for that. thank you !
prateeknayak
pushed a commit
to prateeknayak/avalanche
that referenced
this pull request
Jan 2, 2025
…ometheus-community#68) * changed implementation of shuffleTimeStamps * resolving conflicts and improve test ---------
Member
|
For the record, only now I noticed this change does not introduce OOO as we intended, see #128 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default value of flag is setup to true
run command
./avalanche --remote-url=http://localhost:9090/api/v1/write --out-of-orderto send samples with out-of-order enabled