Merged
Conversation
9bf0e11 to
d3da7e5
Compare
This patch changes the way the link local address is configured in VPP. Previously we were going through the addresses configured on the uplink in linux prior to starting VPP, extracting the Linklocal and using is as-is in VPP. This patch makes it so that we first create the tap interface in linux, wait for it to get a linklocal address and use the new one as a Link local in VPP. This addresses a conflict where linux will compute two different LL addresses for the real uplink - prior to VPP starting - and the tuntap replacing it - after VPP started. This due to the fact that the computation [0] includes idev->dev->perm_addr which is unset in tuntap but is in hardware drivers. Another reason for this design is that VPP does not currently support multiple LL addresses for a given interface. [0] https://github.com/torvalds/linux/blob/master/net/ipv6/addrconf.c#L3337C12-L3337C40 Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
d3da7e5 to
856a14d
Compare
aritrbas
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the way the link local address is configured in VPP. Previously we were going through the addresses configured on the uplink in linux prior to starting VPP, extracting the Linklocal and using is as-is in VPP.
This patch makes it so that we first create the tap interface in linux, wait for it to get a linklocal address and use the new one as a Link local in VPP.
This addresses a conflict where linux will compute two different LL addresses for the real uplink - prior to VPP starting - and the tuntap replacing it
Another reason for this design is that VPP does not currently support multiple LL addresses for a given interface.
[0] https://github.com/torvalds/linux/blob/master/net/ipv6/addrconf.c#L3337C12-L3337C40