feat: Add translation support for motd (WIP) #154
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces translation support for the MOTD, starting with French. The implementation involves determining the system language and loading the appropriate template and tips files. The changes look good overall, but I found a critical issue in env.sh where a relative path is used to find the list of available languages. This will cause the language detection to always fall back to English. I've left a specific comment with a suggested fix to address this.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I was wondering to myself if it was possible to add translations to the motd.
So I tested a bit, and here you go ! 👍
It's still a draft PR because I still need to fully translate it in french (ofc) and I'm not sure about my changes in env.sh.
Any feedback is welcome ! 😄
(Of course, if it works out here, it will also be added to Bazzite and Aurora)