-
Notifications
You must be signed in to change notification settings - Fork 120
Made changes to Atomic App instructions, run command in response to #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,22 +6,23 @@ instructions for building it. | |
| ## Atomic.app | ||
|
|
||
| The recommended way to test the site is with [atomic.app](https://github.com/projectatomic/atomicapp). Currently, | ||
| verion 0.4.2 or later is required. | ||
| version 0.4.2 or later is required. | ||
|
|
||
| ### First time setup | ||
|
|
||
| There are a few setup steps you need to do the first time you clone | ||
| the repository and run this as an atomic app. You should have to do these again | ||
| unless you re-clone the repo for some reason. | ||
| The first time you run it in Atomic App, you'll need to generate an answers.conf | ||
| file with information it needs to launch the container. You shouldn't have to | ||
| do this on successive runs unless you delete the answers.conf file for some | ||
| reason. | ||
|
|
||
| 1. authorize directory sharing in SELinux (may not be required in a VM): | ||
| 1. run genanswers: | ||
|
|
||
| ``` | ||
| ./selinux_share.sh | ||
| ``` | ||
| ``` | ||
| cd /path/to/atomic-site/Nulecule/ | ||
| atomicapp genanswers . | ||
| ``` | ||
|
|
||
| 2. configure answers.conf by copying Nulecule/answers.conf.sample to answers.conf | ||
| and editing the contents. | ||
| 2. edit answers.conf to match your setup. | ||
|
|
||
| For answers.conf, the two things you are required to set is the full file paths | ||
| to the two directories, /source and /data. The other fields should not require | ||
|
|
@@ -33,6 +34,7 @@ Once you've done the setup, you should be able to do this to run the container | |
| each time and test the atomic site by running from the repository root: | ||
|
|
||
| ``` | ||
| cd /path/to/atomic-site/ | ||
| sudo atomicpp run Nulecule/ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo, should be |
||
| ``` | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| docker run --rm -p $hostport:4567 --volume $sourcedir:/tmp/source --volume $datadir:/tmp/data $image | ||
| docker run --rm -p $hostport:4567 --volume $sourcedir:/tmp/source:z --volume $datadir:/tmp/data:z $image |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run immediately into this: projectatomic/atomicapp#652