Skip to content

Conversation

@AndrewWestberg
Copy link
Member

No description provided.

@AndrewWestberg AndrewWestberg requested a review from Copilot July 16, 2025 03:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates how instants are handled in serializers/tests, adjusts API defaults, and refreshes build configurations and dependencies.

  • Migrate from kotlinx.datetime.Instant to kotlin.time.Instant in serializers and model classes.
  • Introduce default null values for guardrails and ancestor in governance action data classes.
  • Clean up test imports and minor code/style tweaks in tests.
  • Increase default client request timeout, bump Gradle wrapper, and update dependency versions.

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/kotlin/io/newm/kogmios/protocols/statequery/StateQueryTest.kt Replace kotlinx.datetime.Instant import with kotlin.time.Instant.
src/test/kotlin/io/newm/kogmios/protocols/chainsync/ChainSyncTest.kt Uncomment relevant PointDetail block, simplify casts, and fix string interpolation.
src/main/kotlin/io/newm/kogmios/protocols/model/serializers/InstantResultSerializer.kt Swap out InstantIso8601Serializer for manual kotlin.time.Instant parsing/serialization.
src/main/kotlin/io/newm/kogmios/protocols/model/result/InstantResult.kt Update import to kotlin.time.Instant.
src/main/kotlin/io/newm/kogmios/protocols/model/result/GenesisConfigResult.kt Update import to kotlin.time.Instant.
src/main/kotlin/io/newm/kogmios/protocols/model/GovernanceAction.kt Add = null defaults for guardrails and make ancestor optional.
src/main/kotlin/io/newm/kogmios/Client.kt Increase DEFAULT_REQUEST_TIMEOUT_MS from 5000L to 10_000L.
gradlew Fix printf '%s\n' newline escape in APP_HOME assignment.
gradle/wrapper/gradle-wrapper.properties Bump Gradle distribution URL to version 8.14.3.
buildSrc/src/main/kotlin/Versions.kt Bump various library and plugin versions; replace MAVEN_REPO_AUTH_PLUGIN with MAVEN_PUBLISH.
Comments suppressed due to low confidence (3)

src/main/kotlin/io/newm/kogmios/protocols/model/GovernanceAction.kt:21

  • Defaulting guardrails to null changes the API contract; confirm that consumers can handle missing guardrails and consider documenting the default behavior.
    val guardrails: GuardrailsHash? = null,

src/main/kotlin/io/newm/kogmios/protocols/model/GovernanceAction.kt:57

  • Making ancestor optional could break existing clients expecting a non-null value; ensure this change is intentional and update documentation or API versioning if necessary.
    val ancestor: UtxoInput? = null,

buildSrc/src/main/kotlin/Versions.kt:15

  • The removal of MAVEN_REPO_AUTH_PLUGIN and addition of MAVEN_PUBLISH suggests changes in publishing setup; verify that build scripts are updated and no plugin references are left dangling.
    const val MAVEN_PUBLISH = "0.34.0"

@AndrewWestberg AndrewWestberg force-pushed the STUD-481-newm-chain-failure-deserializing branch from e0314f7 to 1d4ad95 Compare July 16, 2025 03:14
@AndrewWestberg AndrewWestberg force-pushed the STUD-481-newm-chain-failure-deserializing branch from 1d4ad95 to 1fbd3a5 Compare July 16, 2025 03:14
@AndrewWestberg
Copy link
Member Author

tests pass locally as they require an ogmios instance to run.

@AndrewWestberg AndrewWestberg merged commit 68ef984 into master Jul 16, 2025
1 of 2 checks passed
@AndrewWestberg AndrewWestberg deleted the STUD-481-newm-chain-failure-deserializing branch July 16, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants