"Combining complex line shape and fake data generator" #67
Conversation
…nalysis.py configurable
…ps://github.com/project8/mermithid into simulated_ins_resolution_in_fake_data_generator
cclaessens
left a comment
cclaessens
left a comment
There was a problem hiding this comment.
I think a lot of this is in good shape. I suggest to add a little more description to the test_analysis scripts and the FakeDataGenerator and the MultiGasComplexLineshape processors. Make a note that they were used for Phase II analysis and describe how to use them.
The MultiGasLineshape processor is too long and has a lot of functions that we didn't use. At least everything related to the triangle response function can be deleted.
Add comments to the resolution function and other options in this processor that were used by the FakeDataGenerator for the official analysis.
|
The two line shape functions called are make_spectrum_simulated_resolution_scaled_fit_scatter_peak_ratio() and make_spectrum_gaussian_resolution_fit_scatter_peak_ratio(), which can be seen around this line https://github.com/project8/mermithid/blob/combining_ComplexLineShape_and_FakeDataGenerator/mermithid/misc/FakeTritiumDataFunctions.py#L317 |
…xed_survival_probability_partially_fixed_scatter_proportion(self, bins_Hz, eff_array, *p0) function
…he function spectrum_func_composite_gaussian_lorentzian_fixed_survival_probability_partially_fixed_scatter_proportion() around line number 2025
…. Addressed other comments by Christine in PR #67.
…tps://github.com/project8/mermithid into combining_ComplexLineShape_and_FakeDataGenerator
…tions and relevance to the Phase II analysis
|
Building off of Yu-Hao's work, I expanded the file description at the top of the MultiGasComplexLineShape processor to explain how it is used in the Phase II analysis and correct some details. I added similar descriptions to the tops of the test_analysis scripts and the FakeDataGenerator. |
…d for the scatter peak amplitude
…ed to match the total counts of the data histogram to be fitted
Branch used for Phase II Bayesian analysis.
Many of the comments on this unresolved PR likely apply, here: #53.