-
Notifications
You must be signed in to change notification settings - Fork 0
Release/2.1.0 #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release/2.1.0 #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dl-py to v4.7.1
…ived add_auth_spec
Feature/add auth spec
…iller. Commands are assembled by hex command number and followed by a number of databits and the data itself. For get messages no data are transmitted.
…e communicates in hex code and have no terminator character. They have a fixed header consisting of a leading character, definition of lsb and msb order followed by a command represented by hex number. The header ends with the number of data bits that are send. The next N bits (as specified in the header) are data bits. It follows a checksum. Communication relies on first reading header, extracting number of data bytes, reading databytes and checksum and checking the full message. The class was tested and worked.
… now conversion from config file str to command is fixed
…not need to be in bytes. Handling of hex conversion to bytes happens in service now. Command from entity is now base_cmd + data, service checks the number of bytes and formats the command correctly. For get commands only the base_cmd is required, while for set now the data can be directly attached in hexstr format. This allows for easier implementation of the entities that also implment set or any other type.
…ring and not a numeric value, we use that for status strings
I modified the EthernetThermoFisherService to now inherit from EthernetSCPIService. This now uses the _reconnect method and no changes to send_to_device are needed. I make use of the EthernetSCPIService.__init__ . Also the acknowledge at reconnect is now tested. _send_commands is overwritten but simplified compared to earlier version, since the connection is now handled elsewere. The _listen method is not used.
…vice. We check kwargs and add the defaults if they are not present
…t service. Till now we added the ability to send messages to slack using a slack_hook. Next we will do some diagnostics on docker containers itself.
…onfly stand alone script. That has several advantages, one of it being that we do not depend on rabbit broker, and thus the checks still work if rabbit broker went down.
…mented by Paul K. but not yet rolled out. We should update this once the fix is rolled out.
…ong in your setup. There are two different types of checks: 1. we check if all docker containers are running and not having errors, 2. we check some endpoints and see if they fullfill some condition. If there are problems we send a message to slack. The script is configured by a yaml file. The example yaml file is included as well as a docker-compose file that gives an example how to setup that script with docker compose. Testing this script worked well.
…bles it to prevent others posting to your workspace, this is a place holder and just for demonstration purpose
…you do not need to bind it from external, just the config file is needed
…We add a comment on how an alternative way to implement it could look like, but since we can not test it, we leave the current version.
…evice or rabbit broker is down, we want this script to not crash at all
… presure gauge values. There were no type conversion for numbers, the method was fixed / hard coded to 'not_equal' and the error message came not through correctly. We fixed it by adding type conversion based on the value type itself, using the method provided in the config file and getting the error messages through.
…receive a signal and also notifies when the alarm system stopped (which is also caused by a signal).
…onment variables instead
…the example folder
Feature/chiller integration
Feature/watchdog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.