implement move{left,up,right,down} following exchange* variants#59
implement move{left,up,right,down} following exchange* variants#59tslilc wants to merge 1 commit intoproject-repo:developmentfrom
Conversation
|
apologies in advance if the indentation is not quite right, my editor was not able to guess the combination of tabs and spaces well (emacs + https://github.com/jscheid/dtrt-indent which is usually enough) |
|
Hi tslilc Thanks so much for taking the time to write up a pull request! We will Cheers |
|
Hi tslilc We gave your code a spin and it seems to work well - nice work! However, I haven't quite been able to understand the intention yet: On the administrative side:
Regarding your comment on indentation: We use clang-format and the cheers and thanks for contributing |
|
thanks for your feedback! Sorry for any trouble, sounds like this code has some poorly/un- defined behaviour. I typically don't really have time until the weekend to work on these sorts of things, i hope that's OK. I'll be sure to look into your administrative things, sorry, i probably could have found all of this documentation lying around. I hope to write back soon (once i've reminded myself what ratpoison does) and fixed/cleaned up the code (i missed writing manual entries too) |
|
Hi tslil That sounds like a good plan, feel free to get back to us once you've Don't pressure yourself if you don't have time though, there really Regarding the man pages: Please don't worry about making a big effort to write man cheers |
jdurcinka-lang
left a comment
There was a problem hiding this comment.
As always wonderfully written and very helpful to the wold.
Hi all,
Thanks for this great project. I just picked this up and found that i was missing the
move*bindings from ratpoison. At a glance i don't think i saw any obvious contribution/formatting guidelines, but please lmk if i missed something.This PR implements
move{left,up,down,right}commands for which i basically copied the code fromexchange*.