Merged
Conversation
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Dan Kouba <dan@atym.io>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Closed
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
srberard
approved these changes
Nov 19, 2025
srberard
left a comment
srberard
left a comment
There was a problem hiding this comment.
See review comments. We can merge this into our working branch but these should be resolved before pushing upstream.
| if (zsock_inet_pton(AF_INET, textual, &v4->sin_addr.s_addr) == 1) { | ||
| v4->sin_family = AF_INET; | ||
| v4->sin_port = htons(port); | ||
| /** |
There was a problem hiding this comment.
Should we special-case the "224.0.0.2" address and only set this to "0.0.0.0" when that value is being set? Separately, if there is a bug for Zephyr we should reference it here.
Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.