Merged
Conversation
Signed-off-by: SorinO <sorin.olari2@gmail.com>
Signed-off-by: SorinO <sorin.olari2@gmail.com>
casaroli
reviewed
Jan 30, 2026
| CONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=10485760 | ||
| CONFIG_UART_NATIVE_PTY_0_ON_STDINOUT=y | ||
| CONFIG_UART_NATIVE_PTY=y | ||
| CONFIG_ETH_NATIVE_TAP=n |
Contributor
There was a problem hiding this comment.
I suggest we put the (Socket offloading configuration) in a separate config file like it is done here: https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/net/sockets/echo_server/overlay-nsos.conf
Contributor
There was a problem hiding this comment.
omg the code snippet in the comment went wrong. this is not about the PTY but about the socket offloading
casaroli
reviewed
Jan 30, 2026
casaroli
reviewed
Jan 30, 2026
casaroli
reviewed
Jan 30, 2026
casaroli
requested changes
Jan 30, 2026
Contributor
casaroli
left a comment
There was a problem hiding this comment.
Lets try to keep the specific native sockets implementation in a separate config file, like it is done in echo_server example, in case we want to be able to run with tap (which is the default behavior currently in Zephyr)
casaroli
reviewed
Jan 30, 2026
Signed-off-by: SorinO <sorin.olari2@gmail.com>
casaroli
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration including the following required details.
Test Configuration (required):
Ubuntu 20.04 (arm64)ST Nucleo h723zgSTM32CubeProgrammer)Checklist: