Draft
Conversation
daviddrysdale
force-pushed
the
no-std
branch
7 times, most recently
from
7db1bf3 to
2eb5c31
Compare
Collaborator
Author
|
This currently still pulls in
|
The "json" feature requires the base64 and serde dependencies to have their "alloc" feature enabled.
Requires use of `rand::OsRng` (and with it the `getrandom` feature of the `rand` crate) rather than `rand::thread_rng()`.
This means that there are no details in errors, so remove the test for specific error text.
Move to use the same features of dependencies as the crates under test. This requires a shift from rand::thread_rng() to rand::rngs::OsRng. This crate still uses `std` though.
This commit cannot be included in a release, because it makes the codebase rely on an unreleased crate.
daviddrysdale
force-pushed
the
no-std
branch
from
8aab20e to
66e302b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7