Add more APIC structure logs#5084
Open
CookieComputing wants to merge 1 commit intoproject-oak:mainfrom
Open
Conversation
CookieComputing
commented
Jan 9, 2026
| global_system_interrupt: u32, | ||
|
|
||
| /// See documentation for the various bits set. | ||
| flags: u16, |
Contributor
Author
There was a problem hiding this comment.
I can probably add more detail here and define the flags here: https://github.com/project-oak/oak/blob/main/stage0/src/acpi_tables.rs#L645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CVMs happen to have a few extra APIC structs which would be greatly appreciated if we could get extra logs for. I've taken a look at the spec and added the struct implementations below. I've double checked the fields but let me know if I missed something!
I built this on our servers and ran it, got some of the following logs:
Before this PR
normal_structs.txt
The important logs to look at:
After this PR
new_apic_structs.txt
The important logs to look at: