fix: Handle Drives with existing config from another RAID adapter #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying state from the controller with drives that have existing RAID config, the PhysicalDrive.DG field has the letter 'F' specified. Handle this case by assigning another negative number (-2). Also Allocate a new DGUnknown value (-99) and use this when we encounter another string value that we don't know about rather than crashing. Add a test case for this scenario. Additional changes - Dropped commented out tests - Created const values for the DG properties Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
mikemccracken
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying state from the controller with drives that have existing RAID config, the PhysicalDrive.DG field has the letter 'F' specified. Handle this case by assigning another negative number (-2). Also Allocate a new DGUnknown value (-99) and use this when we encounter another string value that we don't know about rather than crashing.
Add a test case for this scenario.
Additional changes