feat: Add support for LSI/Broadcom MegaRAID 9600 Controllers using storcli2 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
===========================================
- Coverage 66.02% 49.36% -16.67%
===========================================
Files 17 27 +10
Lines 2555 3628 +1073
===========================================
+ Hits 1687 1791 +104
- Misses 661 1623 +962
- Partials 207 214 +7 ☔ View full report in Codecov by Sentry. |
mikemccracken
approved these changes
Feb 5, 2025
mikemccracken
left a comment
mikemccracken
left a comment
There was a problem hiding this comment.
I had a couple comments about the data structure naming being a little confusing, but don't think it's necessary to change to merge this. I have a feeling the confusion is due to the cursedness of the JSON you're having to deal with as input...
Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Not sure why we don't use the values in the Makefile to run this lint, just another place that folks have to know. =( Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Newer MegaRAID controllers require an updated cli tool, storcli2 These controllers use a new kernel driver, mpi3mr. The partial upside is that storcli2 does emit JSON output. But as one has come to expect from LSI/Broadcom/MegaRAID, the output is well... (╯°□°)╯︵ ┻━┻. The fields change the data types, sometimes there are nested structures that hold nothing. But it's better than whitespace parsing ¯\_(ツ)_/¯ - added go-cmp module - dropped the megaraid/storcli interface and utilized the existing storcli2 JSON structures. Added some modifications to the VirtualDrive structuret to hold all of the data needed to map a /dev/sdX device to the VirtualDisk and all properties - Added mpi3mr support into the demo binary Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
raharper
force-pushed
the
feat/add-storcli2-support
branch
from
0c254ed to
b624a5c
Compare
Collaborator
Author
|
Thanks @mikemccracken I just squash rebased and signed the commits. |
mikemccracken
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer MegaRAID controllers require an updated cli tool, storcli2
These controllers use a new kernel driver, mpi3mr. The partial upside
is that storcli2 does emit JSON output. But as one has come to expect
from LSI/Broadcom/MegaRAID, the output is well... (╯°□°)╯︵ ┻━┻.
The fields change the data types, sometimes there are nested structures
that hold nothing. But it's better than whitespace parsing ¯\(ツ)/¯
storcli2 JSON structures. Added some modifications to the
VirtualDrive structuret to hold all of the data needed to map a
/dev/sdX device to the VirtualDisk and all properties
Additional Changes:
Signed-off-by: Ryan Harper ryaharpe@cisco.com