Try to register the nightly job #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallyn
force-pushed
the
2025-11-17/nightly
branch
from
3487488 to
9215f81
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 40.27% 39.47% -0.80%
==========================================
Files 24 24
Lines 1758 1758
==========================================
- Hits 708 694 -14
- Misses 872 892 +20
+ Partials 178 172 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move nightly.yml to .github/workflows, in the hopes that makes it show up. Add workflow_call to the build.yaml triggers, else nightly.yaml can't call it. Have build.yaml inherit all secrets from nightly.yaml. actionlint had a warning about the previous version. Signed-off-by: Serge Hallyn <shallyn@cisco.com>
update some dependencies, and escape $HOME Signed-off-by: Serge Hallyn <shallyn@cisco.com>
Signed-off-by: Serge Hallyn <shallyn@cisco.com>
hallyn
force-pushed
the
2025-11-17/nightly
branch
from
0c8beca to
c500671
Compare
Contributor
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow advice of actionlint on some things that would make the nightly job not runnable.
Of course we can't really test it without merging (I don't think).