fix: Include tag matching for MAIN_VERSION used in --version output #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 38.50% 38.50%
=======================================
Files 24 24
Lines 2254 2254
=======================================
Hits 868 868
Misses 1208 1208
Partials 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikemccracken
approved these changes
Aug 11, 2025
raharper
force-pushed
the
fix/atomfs-version-from-tag
branch
from
d230a39 to
464c674
Compare
raharper
changed the title
The atomfs --version output should match the build version; currently it either shows just the git hash, or an incorrect older tag plus hash. For example v1.2.0 was tagged back in early 2025, but if you build tip of the tree, the --version shows 1.1.2-XXXX $ ./bin/atomfs --version v1.1.2-9-gb584303 Add --tags to the git-describe output to match tags as well. Fixes: project-machine#45 Signed-off-by: Ryan Harper <rharper@woxford.com>
raharper
force-pushed
the
fix/atomfs-version-from-tag
branch
from
464c674 to
324014f
Compare
mikemccracken
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomfs --version output should match the build version; currently it either shows just the git hash, or an incorrect older tag plus hash. For example v1.2.0 was tagged back in early 2025, but if you build tip of the tree, the --version shows 1.1.2-XXXX
$ ./bin/atomfs --version
v1.1.2-9-gb584303
Add --tags to the git-describe output to match tags as well.
Fixes: #45