Skip to content

Conversation

@debovema
Copy link
Contributor

This pre-processing is conflicting with secret.PropertyProcessor at

func PropertyProcessor(properties map[string]interface{}) error {

@fm-tibco
Copy link

@mellistibco General question... should we support secrets only in properties? Or anywhere in the flogo.json. If its just used in properties, it makes the secret management easier and also easier to refer to in other places (you only have to set it once). The only question is it too burdensome if someone just has one secret? Would it be too much to ask to force them to use a property?

@mellistibco
Copy link
Contributor

I tend to think that we should support SECRET: anywhere, especially considering the ui doesn't currently support adding and editing properties...

@fm-tibco
Copy link

Does it assist in generating a "secret"?

@debovema debovema force-pushed the remove-json-pre-processing branch from 410ae00 to a4df946 Compare January 21, 2019 15:01
@debovema
Copy link
Contributor Author

I think the secrets can be used anywhere (using the expression syntax =$property[some.secret] but should be declared only in properties for consistency reason.

Even if the UI assists in generating a secret, it can do it in the properties section. Currently the "SECRET:..." patterns can be directly put in the activities configuration which is not a good practice IMHO.

Other use case is the ability to use a plain-text property and change it later in the development to a secret one.

Eventually, this PR is just about removing the duplicate processing of "SECRET:..." pattern, not about changing the secret resolving method (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants