Fix is_dollar_amount() to accept strings cast from single precision floats. Ensure no mixed dtypes before to_parquet()#107
Open
radkoff wants to merge 1 commit intoproject-deepform:masterfrom
Conversation
…loats. Ensure no mixed dtypes before to_parquet().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes here
10.5instead of10.51), and the existingis_dollar_amountdoes not recognize it. This means a perfect match is not detected indollar_match(), which was causing my results to be much lower than expected. I saw it happening in your baseline results too (❌ gross_amount: guessed "$1,510.00" with score 0.903, was actually "$1,510.0"), so if you guys pull this and rerun, you should see a higher score forgross_amount