Cleaning up the broken functionality for UI not catching the errors from SQL Triggers

[brdandu]

JIRA: ZAPP-1696

[gemini-code-assist]

Summary of Changes

Hello @brdandu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the UI was failing to properly catch and display errors generated by SQL triggers. It enhances error handling mechanisms in both the backend (Electron's database query functions) and the frontend (Axios request interceptors) to ensure that these errors are robustly processed, formatted, and presented to the user through clear notifications. The changes aim to provide a more reliable and informative user experience when database constraints or business rules are violated.

Highlights

• Improved SQL Trigger Error Handling: Standardized the extraction and formatting of error messages originating from SQL triggers in query-config.js, ensuring they are consistently captured, trimmed, and passed to the notification system.
• Enhanced UI Error Notifications: Implemented client-side error notifications using Quasar's Notify component for axios POST and PATCH requests, providing users with immediate and user-friendly feedback on failed operations.
• Added Error Propagation Test: Introduced a new test case to verify that the insertEndpointType function correctly throws errors originating from SQL triggers, specifically for scenarios involving multiple Matter application device types on a simple endpoint.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src-electron/db/query-config.js
  • Standardized error object to string conversion and trimming for SQL trigger errors.
  • Ensured the processed error string (errStr) is consistently thrown after notification.
• src/boot/axios.js
  • Imported Notify component from quasar for UI notifications.
  • Added a catch block to serverPost and serverPatch to display UI notifications for request failures.
  • Improved error message extraction from axios response objects, providing a fallback message.
• test/gen-matter-3-1.test.js
  • Added a new test case to confirm insertEndpointType correctly rejects with a specific error message when a SQL trigger prevents adding multiple application device types to a simple endpoint.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves error handling by making sure errors from SQL triggers are properly caught and propagated to the UI. The changes in the backend robustly handle different error object formats, and the frontend changes ensure that API errors are displayed to the user as notifications. A new test case has been added to verify the backend error handling.

The changes are well-implemented. I've added a couple of suggestions to refactor duplicated error-handling logic into helper functions to improve maintainability.

[gemini-code-assist]

This catch block is identical to the one in serverPost (lines 139-148). To avoid code duplication and improve maintainability, you could extract this error handling logic into a shared helper function. This function could take error and data as parameters.