ZAPP-1695: Enable toggling desc features to fix the TagList feature issue

[ethanzhouyc]

Before, ZAP disabled toggling desc features as the complex descriptive conformance might lead to wrong cluster state.

But we should not restrict users. Since we have issues on unable to toggle the TagList feature, now we enable toggling desc features and will display a warning instead.

See ZAPP-1695 for issue details.

[gemini-code-assist]

Summary of Changes

Hello @ethanzhouyc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances user flexibility by allowing the toggling of features that involve descriptive conformance, a capability previously restricted due to concerns about potential cluster state complexities. The modification replaces the hard restriction with a warning system, ensuring users can manage these features while being informed of their intricate nature. This change specifically resolves an issue preventing certain features, such as TagList, from being toggled.

Highlights

• Enabled Toggling of Descriptive Features: The previous restriction that disabled toggling features with descriptive conformance ('desc' operand) has been removed, allowing users to enable or disable these features.
• Introduced Warning for Complex Conformance: Instead of outright disabling the toggle for features with descriptive conformance, the system now displays a warning message to inform the user about the complexity.
• Resolved TagList Feature Issue: This change directly addresses an issue where features like TagList, due to their descriptive conformance, could not be toggled by the user.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src-electron/validation/conformance-checker.js
  • Removed the code block that explicitly checked for and disabled toggling of features containing the 'desc' operand in their conformance.
  • Adjusted the numbering of subsequent conformance checks (e.g., 'Check 4' became 'Check 3').
  • Modified the conditional logic for determining if a feature update is disabled, removing the !featureContainsDesc condition.
  • Reintroduced logic to detect features with 'desc' conformance, but instead of disabling, it now generates a warning message and sets displayWarning to true.

Activity

• The pull request was created by ethanzhouyc.
• The PR title indicates it addresses ZAPP-1695.
• The description clarifies that the change enables toggling descriptive features, which were previously restricted due to concerns about complex descriptive conformance, and now displays a warning instead to fix the TagList feature issue.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables the toggling of features with descriptive conformance, which was previously disabled, and instead displays a warning. This is a sensible change that improves user experience. The implementation is correct, and I've provided one suggestion to make the code more efficient and maintainable by removing a redundant check.

[brdandu]

Add unit tests to just check for that message so behavior is not changed over time.

[ethanzhouyc]

Unit test added