Skip to content

Disable adhoc signing for mac-arm64 package#1682

Draft
dhchandw wants to merge 2 commits intoproject-chip:masterfrom
dhchandw:task/fix-mac-arm64-package
Draft

Disable adhoc signing for mac-arm64 package#1682
dhchandw wants to merge 2 commits intoproject-chip:masterfrom
dhchandw:task/fix-mac-arm64-package

Conversation

@dhchandw
Copy link
Collaborator

@dhchandw dhchandw commented Feb 5, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dhchandw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the build configuration to disable ad-hoc signing for macOS ARM64 packages. By setting an empty identity in the package.json, the build process will no longer apply ad-hoc signatures, which can be necessary for specific distribution workflows or to avoid conflicts with other signing processes.

Highlights

  • macOS Signing Configuration: The package.json file has been updated to explicitly set an empty identity for macOS builds under the mac configuration. This change effectively disables ad-hoc signing for the mac-arm64 package, aligning with the pull request's objective.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Disabled ad-hoc signing for macOS ARM64 builds by adding an empty identity field to the mac configuration.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables ad-hoc code signing for macOS builds by setting identity to an empty string in package.json. While this addresses the goal stated in the PR title, the change currently applies to both x64 and arm64 architectures. I've suggested a refinement to limit this change only to the arm64 architecture to more closely match the PR's intent and avoid unintended side effects on the x64 build.

@dhchandw dhchandw marked this pull request as draft February 5, 2026 17:52
@dhchandw dhchandw force-pushed the task/fix-mac-arm64-package branch from 9a55463 to 911cf66 Compare February 5, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant