Disable adhoc signing for mac-arm64 package#1682
Disable adhoc signing for mac-arm64 package#1682dhchandw wants to merge 2 commits intoproject-chip:masterfrom
Conversation
Summary of ChangesHello @dhchandw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the build configuration to disable ad-hoc signing for macOS ARM64 packages. By setting an empty identity in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request disables ad-hoc code signing for macOS builds by setting identity to an empty string in package.json. While this addresses the goal stated in the PR title, the change currently applies to both x64 and arm64 architectures. I've suggested a refinement to limit this change only to the arm64 architecture to more closely match the PR's intent and avoid unintended side effects on the x64 build.
9a55463 to
911cf66
Compare
No description provided.