Merged
Conversation
Based implementation from kedars/matter-rs#18
90046fd to
77a0e3d
Compare
kedars
approved these changes
Feb 9, 2023
|
FWIW libmdns supports windows too |
|
librespot-org/libmdns#43 released as 0.7.4 |
Contributor
Author
Oh cool, I missed that - maybe this thing can run on all platforms at some point like the C++version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation is from kedars/matter-rs#18
This implements mdns for Linux targets. Using patched version of libmdns as currently it does not properly respond to queries of type ALL (255) - so commands from chip-tool just hang as they can't find the correct host.
Waiting for upstream merge in librespot-org/libmdns#42 , after which we can go back to using the official repo.