-
Notifications
You must be signed in to change notification settings - Fork 5
Added the detailed instruction for validating this test on reference platform #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # | ||
| # Copyright (c) 2023 Project CHIP Authors | ||
| # Copyright (c) 2023-2026 Project CHIP Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
|
|
@@ -44,8 +44,7 @@ def pics(cls) -> set[str]: | |
| def create_test_steps(self) -> None: | ||
| self.test_steps = [ | ||
| TestStep( | ||
| "Step1: Scan the DUT’s QR code using a QR code\ | ||
| reader and verify the number of delimiters." | ||
| "Step1: Scan larger QR code that will support the commissioning of all the DUTs in the packaging using the QR code scanner" | ||
| ), | ||
| ] | ||
|
|
||
|
|
@@ -81,7 +80,23 @@ async def cleanup(self) -> None: | |
|
|
||
| def _create_qr_code_payload_prompt(self) -> PromptRequest: | ||
| text_input_param = { | ||
| "prompt": "Please enter the concatenated QR code payload", | ||
| "prompt": """Please enter the concatenated QR code payload. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @KishokG Do you think we need this PR ? DUTs will have concatenated QR codes, we don't need to mention on how to generate the QR codes.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cjandhyala You’re correct — DUTs will have concatenated QR codes. This minor instruction is only required when validating with the reference platform (RPI), and I’ve mentioned that in the script as well. Technically, this change does not add functional value, but it will be helpful for those validating the script using RPIs. |
||
|
|
||
| Note: The reference platform(e.g., all-clusters-app) advertises only a single QR code, which is not sufficient to validate | ||
| concatenated QR code onboarding payloads. Therefore, the QR code payloads must be manually generated using chip-tool. | ||
|
|
||
| Use the following commands to generate individual QR codes: | ||
|
|
||
| ./chip-tool payload generate-qrcode --discriminator 3840 --setup-pin-code 20202021 --vendor-id 65521 --product-id 32768 | ||
| ./chip-tool payload generate-qrcode --discriminator 3841 --setup-pin-code 20202021 --vendor-id 65522 --product-id 32770 | ||
|
|
||
| Save the generated QR codes. To create the concatenated payload, join the individual payloads with a '*' delimiter, removing the 'MT:' prefix from the second and any subsequent payloads. | ||
|
|
||
| Example of a concatenated payload: MT:YNJV75HZ00KA0648G00*W0GU2OTB00KA0648G00 | ||
|
|
||
| The above steps are required only for the reference platform. Please skip these when validating with real devices and | ||
| directly enter the concatenated QR code payload. | ||
| """, | ||
| "placeholder_text": "MT:YNJV75HZ00KA0648G00*W0GU2OTB00KA0648G00", | ||
| } | ||
| prompt_request = TextInputPromptRequest( | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.