[Feature] Update the Test Selection With Pydantic & Remove TestRunConfig#16
Closed
antonio-amjr wants to merge 8 commits intoproject-chip:spring2025from
Closed
Conversation
Contributor
ccruzagralopes
left a comment
There was a problem hiding this comment.
I don't know if you remembered this, but you'll probably need to update CLI as well
hiltonlima
approved these changes
Nov 6, 2023
mikaelhm
approved these changes
Nov 6, 2023
Contributor
Author
No, I was not remembering. I'll take a look. Thanks |
Contributor
Author
|
@ccruzagralopes @mikaelhm The CLI PR change was created: Please review when possible. Thanks |
173ed54 to
c1945a0
Compare
c1945a0 to
dd71236
Compare
rquidute
approved these changes
Nov 24, 2023
64665b7 to
770a995
Compare
ccruzagralopes
approved these changes
Nov 29, 2023
770a995 to
be1f18d
Compare
Mistyping of iterations parameter was removed
109cab1 to
8707de0
Compare
Contributor
Contributor
|
Please target to branch |
4f87387 to
316a934
Compare
ad73477 to
0bb4f89
Compare
rquidute
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Removed invalied json data * Fix JSON parsing issue by removing invalid data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Test Selection uses a set of dictionaries to store the tests chosen by the user.
This change removes that set of dictionaries replacing by objects with Pydantic's BaseModel, since Pydantic brings some advantages.
Fixes: project-chip/certification-tool#64
This change is considering: #6
Warning: This may impact the Frontend side, since the JSON request data sent to the Backend's API (
createTestRunExecution).The current JSON data format being used is:
Now the new JSON data format would be: