Update cb2.gemspec to support redis 4.x and 5.x gem versions#17
Update cb2.gemspec to support redis 4.x and 5.x gem versions#17prognostikos merged 5 commits intoprognostikos:masterfrom
Conversation
PR to support issue: prognostikos#16
|
@acunningham-fz I think you'll need to run |
|
ugh - apologies @prognostikos - I should know better than to put up a PR without doing the local verification. The smallest changes are always the ones that bite me 😆 . Done the update of the |
|
@acunningham-fz thanks it looks good. One thing that could be improved is changing CI so that we explicitly test against the latest 4.x and 5.x versions of the redis gem. However if you're not interested in that let me know and I will merge as-is. |
|
I'll merge this and add the tests. |
|
thank you! sorry, I actually found a nice pattern using appraisal but hadn't found the time to give it a go but saw your solution which is pretty much the same so will leave it. Thanks for taking the time to work through this, very much appreciate it. |
PR to support issue: #16